[Coral-Schema] default value lowercasing #560
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request, and why are they necessary?
This PR fixes a bug in
ToLowercaseSchemaVisitorwhere field names within complex default values were not being lowercased, causing schema validation errors when creating fields with lowercased schemas.Given an input schema with a record field that has a default value:
Before the fix:
Result:
AvroTypeException: Invalid default for field struct_fieldAfter the fix:
The Solution:
Added
lowercaseDefaultValue()method that recursively transforms default values based on the schema type:The implementation handles both
GenericData.RecordandMap-based default value representationsHow was this patch tested?
Added a new test
testLowercaseSchemaWithComplexDefaultValues()inSchemaUtilitiesTeststhat verifies the fix handles:The test uses input/expected schema files:
testLowercaseSchemaWithDefaultValues-input.avsc- Contains fields with various default values using mixed casetestLowercaseSchemaWithDefaultValues-expected.avsc- Contains the fully lowercased expected outputAll existing tests continue to pass, confirming backward compatibility.